Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External participants not being found in participant list #93

Closed
coleslaw481 opened this issue Oct 24, 2016 · 1 comment
Closed

External participants not being found in participant list #93

coleslaw481 opened this issue Oct 24, 2016 · 1 comment
Assignees
@coleslaw481
Labels
bug
Milestone
1.6.1

Comments

@coleslaw481
Copy link
Contributor

Looks like the participant_list.csv on 2016 week 41 & 42 were saved on a windows machine cause each line is separated by a carriage returns. To fix this, ParticipantDatabaseFromCSVFactory class needs to be modified to properly parse a participant_list.csv written from windows or with any tool that uses carriage returns
@coleslaw481 coleslaw481 added this to the 1.6.1 milestone Oct 24, 2016
@coleslaw481 coleslaw481 self-assigned this Oct 24, 2016
coleslaw481 added a commit that referenced this issue Oct 24, 2016
@coleslaw481
Fix for issue #93
3c64717
@coleslaw481
Copy link
Contributor Author

Switched read method in participant.py module to use 'rU' for read flag to handle carriage returns. Fixed in 2a5fd5d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleslaw481 coleslaw481

Labels
bug
Projects
None yet
Milestone
1.6.1
Development

No branches or pull requests
1 participant
@coleslaw481