Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodDisruptionBudget API changed #346

Open
domenicbove opened this issue Jan 11, 2024 · 1 comment
Open

PodDisruptionBudget API changed #346

domenicbove opened this issue Jan 11, 2024 · 1 comment

Comments

@domenicbove
Copy link

Hi! We recently upgraded K8s versions (to 1.28). And the operator is giving this error:

1.704997223775299e+09   ERROR   druid_operator_handler  failed to list [PodDisruptionBudget] due to [no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"]     {"name": "druid", "namespace": "druid", "error": "failed to list [PodDisruptionBudget] due to [no matches for kind \"PodDisruptionBudget\" in version \"policy/v1beta1\"]"}
github.com/druid-io/druid-operator/controllers/druid.deleteUnusedResources
        /workspace/controllers/druid/handler.go:636
github.com/druid-io/druid-operator/controllers/druid.deployDruidCluster
        /workspace/controllers/druid/handler.go:346
github.com/druid-io/druid-operator/controllers/druid.(*DruidReconciler).Reconcile
        /workspace/controllers/druid/druid_controller.go:66
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:114
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:311
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227

From the code, it looks like yall are using v1beta1:

func makePodDisruptionBudget(nodeSpec *v1alpha1.DruidNodeSpec, m *v1alpha1.Druid, ls map[string]string, nodeSpecUniqueStr string) (*v1beta1.PodDisruptionBudget, error) {

But the PDBs now are policy/v1

Is there anyway to skip the creation of PDBs while this is getting resolved?

@AdheipSingh
Copy link
Contributor

AdheipSingh commented Jan 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants