Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the documentation: Field accessor post-aggregator #1584

Closed
MarConSchneid opened this issue Jul 31, 2015 · 4 comments · Fixed by #1629
Closed

Error in the documentation: Field accessor post-aggregator #1584

MarConSchneid opened this issue Jul 31, 2015 · 4 comments · Fixed by #1629

Comments

@MarConSchneid
Copy link
Contributor

Issue open based on the discussion: https://groups.google.com/forum/#!topic/druid-user/zUpDX1H2_Nw

The general example for the Field accessor post-aggregator (http://druid.io/docs/latest/querying/post-aggregations.html) has a wrong syntax:
{ "type" : "fieldAccess", "fieldName" : <aggregator_name> }

and further down the page in the example you can find this code example (which works):
{ "type" : "fieldAccess", "name" : "tot", "fieldName" : "tot" }

With best regards
Martin Schneider

MarConSchneid added a commit to MarConSchneid/druid that referenced this issue Aug 3, 2015
@fjy
Copy link
Contributor

fjy commented Aug 6, 2015

@MarConSchneid do you think you can submit a PR for this fix?

@MarConSchneid
Copy link
Contributor Author

Sorry, for letting you wait, but I'm currently on parental leave. Let me know if I did it correct. (first time for me to contribute to a big project).

@xvrl
Copy link
Member

xvrl commented Aug 12, 2015

@MarConSchneid it looks like you submitted the PR to your own repository instead of druid-io. If it's too much trouble the re-submit, I can merge your changes directly from your repo. We just need you to sign our CLA first here, http://druid.io/community/cla.html Thanks!

@MarConSchneid
Copy link
Contributor Author

@xvrl I've signed the CLA. And sorry for the trouble.

xvrl pushed a commit to metamx/druid that referenced this issue Aug 14, 2015
@fjy fjy closed this as completed in #1629 Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants