TaskActionToolbox: Remove allowOlderVersions, lift interval constraint #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@gianm sounds good, can we put your useful PR comments somewhere in the code? |
|
@xvrl what/where were you thinking of adding? I did add a "word of warning" section about splitting up large segment sets. I didn't add anything about allowOlderVersions, since the lighter more useful constraint is still enforced (your version must be <= the lock version rather than == the lock version). |
|
@gianm do we note anywhere that we "expect tasks to choose versions in some way that makes sense, so long as they don't choose one larger than their taskLock version" |
…nstraint. allowOlderVersions has been stuck true for a while due to a bug (introduced in 566a3a6), but I think it's actually OK this way. I think it's reasonable to expect tasks to choose versions in some way that makes sense, so long as they don't choose one larger than their taskLock version. This is still verified. The interval constraint was introduced to force tasks to break up their segment insert lists into manageable chunks. They are already doing this, and I think it's reasonable to expect them to do so without enforcement. Lifting these constraints paves the way for transactional insertion of segments that have varying versions and may be for varying intervals.
gianm
force-pushed
the
segment-insert-constraints
branch
from
1792871
to
3368152
Compare
|
@xvrl ah, nope, I just added it to the javadoc. |
xvrl
added a commit
that referenced
this pull request
Aug 26, 2015
TaskActionToolbox: Remove allowOlderVersions, lift interval constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowOlderVersions has been stuck true for a while due to a bug (introduced in
566a3a6), but I think it's actually OK this way. I think it's reasonable to
expect tasks to choose versions in some way that makes sense, so long as they
don't choose one larger than their taskLock version. This is still verified.
The interval constraint was introduced to force tasks to break up their
segment insert lists into manageable chunks. They are already doing this, and
I think it's reasonable to expect them to do so without enforcement.
Lifting these constraints paves the way for transactional insertion of segments
that have varying versions and may be for varying intervals.