Add CPUTimeMetricQueryRunner to ClientQuerySegmentWalker #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Looks good assuming it works- I am never really sure with the sequences |
| } | ||
| }, | ||
| emitter, | ||
| new AtomicLong(0L), |
There was a problem hiding this comment.
is there a purpose to passing this value?
There was a problem hiding this comment.
I assume you mean the atomiclong(0). Yes, it goes with the reporting boolean beneath it. If the runner is set to report, then it reports whatever the value of the atomiclong accumulator. It is entirely possible to have multiple runners use the same accumulator and only report once (but that is not the case here)
|
LGTM |
drcrallen
force-pushed
the
brokerCpuMetrics
branch
from
b61c15a
to
2bc4aed
Compare
xvrl
added a commit
that referenced
this pull request
Oct 5, 2015
Add CPUTimeMetricQueryRunner to ClientQuerySegmentWalker
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.