RemoteTaskRunner: Fix for starting an overlord before any workers ever existed. #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
a unit test for this case would be good to have. |
|
Failed on Agree with unit test |
|
LGTM, an UT if possible would be nice |
gianm
force-pushed
the
fix-overlord-startup
branch
from
e31208e
to
63bf021
Compare
|
@drcrallen @himanshug @nishantmonu51 added a test that fails in master. |
|
👍 |
fjy
added a commit
that referenced
this pull request
Sep 25, 2015
RemoteTaskRunner: Fix for starting an overlord before any workers ever existed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the NoNodeException bubbles up, it'll stop the overlord's leader lifecycle from being able to start up and the overlord will not actually be able to do things.