Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasketches: Remove isInputThetaSketch from cache key. #2899

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Datasketches: Remove isInputThetaSketch from cache key. #2899

merged 1 commit into from
Apr 29, 2016

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Apr 28, 2016 •
edited
Loading

@gianm gianm added this to the 0.9.1 milestone Apr 28, 2016
@gianm gianm mentioned this pull request Apr 28, 2016
Merged
@drcrallen
Copy link
Contributor

Does this mean errorBoundsStdDev will not be taken into account?

@gianm
Copy link
Contributor Author

gianm commented Apr 28, 2016

@drcrallen I think this doesn't matter, since it's only applied on finalization so it won't be cached.

@fjy fjy merged commit 67b47c9 into apache:master Apr 29, 2016
@gianm gianm deleted the sketch-cache-keys branch September 23, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gianm @drcrallen @fjy