Deprecate Aggregator.getName and AggregatorFactory.getAggregatorStartValue. #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
force-pushed
the
deprecate-unused-agg-stuff
branch
2 times, most recently
from
e44d06c
to
0ff1988
Compare
leventov
requested changes
Oct 17, 2016
| * Returns the starting value for a corresponding aggregator. For example, 0 for sums, - Infinity for max, an empty mogrifier | ||
| * | ||
| * @return the starting value for a corresponding aggregator. | ||
| * Deprecated, to be removed in 0.10.0. |
There was a problem hiding this comment.
Maybe add something like "see /pull/3572 for details"?
| @@ -37,7 +37,7 @@ | |||
| void reset(); | |||
| Object get(); | |||
| float getFloat(); | |||
| String getName(); | |||
| @Deprecated String getName(); | |||
There was a problem hiding this comment.
Maybe add something like "see /pull/3572 for details"?
nishantmonu51
approved these changes
Oct 18, 2016
gianm
force-pushed
the
deprecate-unused-agg-stuff
branch
from
0ff1988
to
7411985
Compare
|
@leventov @nishantmonu51 I raised #3588 and mentioned it in the javadocs for the deprecated methods. |
gianm
force-pushed
the
deprecate-unused-agg-stuff
branch
3 times, most recently
from
43365a8
to
445bf09
Compare
|
rebased against master, although tests cannot pass until #3624 is merged. |
gianm
force-pushed
the
deprecate-unused-agg-stuff
branch
from
445bf09
to
b6b93e4
Compare
|
rebased against master again. |
|
👍 |
fundead
pushed a commit
to fundead/druid
that referenced
this pull request
Dec 7, 2016
dgolitsyn
pushed a commit
to metamx/druid
that referenced
this pull request
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial rework of #3387, plus deprecating AggregatorFactory.getAggregatorStartValue too. Neither was really used for much. This deprecates rather than removes the functions, to prevent errors for people that have implemented custom aggregators.
From the original PR, this can also help quite a bit with memory use of OnheapIncrementalIndex when there are a large number of aggregators. #3387 (comment)