Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null key in timeseries result for hyperUnique on missing columns #3625

Closed
gianm opened this issue Oct 31, 2016 · 2 comments
Closed

Null key in timeseries result for hyperUnique on missing columns #3625

gianm opened this issue Oct 31, 2016 · 2 comments
Labels
Bug
Milestone
0.10.0

Comments

@gianm
Copy link
Contributor

gianm commented Oct 31, 2016

If the column for a hyperUnique aggregator doesn't exist, a null key appears in the TimeseriesResultValue. If results get combined by TimeseriesBinaryFn, these null keys get filtered out. But if results don't get combined (possibly because only one segment matched the query) then the query fails with a Jackson exception when it tries to serialize the null key, because null keys aren't allowed in JSON.
@gianm gianm added the Bug label Oct 31, 2016
@gianm gianm added this to the 0.9.3 milestone Oct 31, 2016
@gianm
Copy link
Contributor Author

gianm commented Oct 31, 2016

I think I can fix this as part of #3572 since the underlying cause of the null key is that Aggregators.noopAggregator has no name.

gianm added a commit to gianm/druid that referenced this issue Oct 31, 2016
@gianm
Math expressions support for missing columns.
b7ad8e9 
Also add SchemaEvolutionTest to help test this kind of thing.

Fixes apache#3627 and includes test for apache#3625.
@gianm
Copy link
Contributor Author

gianm commented Oct 31, 2016

Fixed in #3572; test case added in #3630. Even though the latter isn't merged yet I'll close this since the bug is fixed.

@gianm gianm closed this as completed Oct 31, 2016
fjy pushed a commit that referenced this issue Nov 1, 2016
@gianm @fjy
Math expressions support for missing columns. (#3630)
45940d6 
Also add SchemaEvolutionTest to help test this kind of thing.

Fixes #3627 and includes test for #3625.
fundead pushed a commit to fundead/druid that referenced this issue Dec 7, 2016
@gianm
Math expressions support for missing columns. (apache#3630)
cd0072d 
Also add SchemaEvolutionTest to help test this kind of thing.

Fixes apache#3627 and includes test for apache#3625.
dgolitsyn pushed a commit to metamx/druid that referenced this issue Feb 14, 2017
@gianm @dgolitsyn
Math expressions support for missing columns. (apache#3630)
f0db068 
Also add SchemaEvolutionTest to help test this kind of thing.

Fixes apache#3627 and includes test for apache#3625.
seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this issue Feb 25, 2022
@navis
apache#3625 Allow table construct for CTAS
63b0528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@gianm