Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace requests library with urllib #128

Open
nishantmonu51 opened this issue May 8, 2018 · 3 comments
Open

Replace requests library with urllib #128

nishantmonu51 opened this issue May 8, 2018 · 3 comments

Comments

@nishantmonu51
Copy link
Member

We need to package superset, pydruid alongwith the dependencies to support offline installations for our clients.
Now the issue is that requests brings in a LGPL dependent library named 'chardet' which we cannot ship in the bundle. (https://github.com/requests/requests/blob/master/setup.py#L46)

On a quick glance at the usage of requests inside pydruid, it seems this can easily be replaced with urllib.

@mistercrunch
Copy link
Member

Oh snap. Both Airflow and Superset use requests as well.

@nishantmonu51
Copy link
Member Author

nishantmonu51 commented May 14, 2018

I looked at the usage in Superset, I found requests usage at limited places when interacting with Druid coordinator.

@mistercrunch Any thoughts on how invasive will be the changes in Airflow required to replace requests usage ?

@mistercrunch
Copy link
Member

mistercrunch commented May 14, 2018

It's bad, 172 references for Airflow.

11:15 $ git grep requests | wc -l
     172

We should probably fork requests to requests-nogpl and start using that. Ideally someone would commit to keep doing matching releases long-ish term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants