Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbapi] Fixing header description #168

Merged

Conversation

john-bodley
Copy link
Contributor

This PR fixes an issue when leveraging Druid's header functionality if the column name starts with an underscore.

Previously we were fetching the description from the Row namedtuple which renames invalid fields, and thus a column named _name say is renamed to _0 (or similar). The logic has been updated to fetch the description from the raw row (similar to how the non-header logic works).

to: @betodealmeida @mistercrunch

@betodealmeida
Copy link
Contributor

LGTM

@mistercrunch mistercrunch merged commit 51315c4 into druid-io:master Jun 14, 2019
@john-bodley john-bodley deleted the john-bodley--dbapi-fix-description branch June 19, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants