Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
abc
is a submodule incollections
and not imported to collections, directly usingcollections.abc.MutableSequence
will cause error in newer versions (I tested it on 3.8.5, but I think 3.7 may have the same issue):And the current code will cause this error:
python -c "from pydruid import client"
.I think this issue was not found because if we run
import collections.abc
orfrom collections.abc import x
before, thecollections.abc
will be added tocollections
. And many thrid party have codes like this.But anyway, I think we should fix this.