DruidBeams: Respect druid.discovery.curator.path in fromConfig. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Can this break things for anyone who has already set druid.discovery.curator.path in their config but defaults were being used prior to this change? |
|
In theory yes, although if someone set btw, till now this property was respected for Server and Kafka, but not Core (i.e. |
|
+1, Added release notes label so that we dont forget to mention this. |
nishantmonu51
added a commit
that referenced
this pull request
Mar 18, 2016
DruidBeams: Respect druid.discovery.curator.path in fromConfig.
|
Can you release a SNAPSHOT version for this issue? We are stuck with this issue or do you have any way to workaround with 0.7.4? |
|
never mind, i built a 0.7.5-SNAPSHOT myself :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150.