Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use default for serializing JSON in logging #103

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Do not use default for serializing JSON in logging #103

merged 1 commit into from
Jun 29, 2020

Conversation

radimsuckr
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jun 4, 2020 •
edited

Coverage Status

Coverage remained the same at 90.315% when pulling ea6497a on radimsuckr:fix/logging-json-encoder into 926d1ca on druids:master.

@radimsuckr radimsuckr changed the title Use str as default function for serializing JSON Do not use default for serializing JSON in logging Jun 4, 2020
@radimsuckr
Copy link
Member Author

@matllubos ping

@matllubos matllubos merged commit 95991cd into druids:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Formulka Formulka Formulka approved these changes

@rubickcz rubickcz rubickcz approved these changes

@matllubos matllubos Awaiting requested review from matllubos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@radimsuckr @coveralls @Formulka @rubickcz @matllubos