Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support django 3 #108

Merged
merged 1 commit into from Jan 12, 2021
Merged

Support django 3 #108

merged 1 commit into from Jan 12, 2021

Conversation

matllubos
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Dec 23, 2020

Coverage Status

Coverage decreased (-9.0%) to 81.431% when pulling 8d080d4 on Django3 into f271eeb on master.

@matllubos matllubos force-pushed the Django3 branch 5 times, most recently from 2bb2d53 to a28fe90 Compare January 2, 2021 14:28
@rubickcz
Copy link
Member

rubickcz commented Jan 5, 2021

Coverage decreased quite significantly :(

@matllubos
Copy link
Collaborator Author

I know. But it shows changes which was not done here. It is weird. I will try to add some tests

def unknown_model_fields_to_dict(instance, fields=None, exclude=None):

return {
field.name: Unknown
for field in chain(instance._meta.concrete_fields, instance._meta.many_to_many) # pylint: disable=W0212
for field in instance._meta.concrete_fields # pylint: disable=W0212
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the chain import is no longer used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants