Add permission caching #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matllubos
force-pushed
the
CachePermissions
branch
from
eada00b
to
8323ab5
Compare
Pull Request Test Coverage Report for Build 1707619652
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1704251446
💛 - Coveralls |
Formulka
reviewed
Jan 16, 2022
| cache = get_cache() | ||
|
|
||
| if cache: | ||
| assert hasattr(request, 'session'), 'The cached permissions requres session middleware to be installed, ' \ |
fperms_iscore/permissions.py
Outdated
| assert hasattr(request, 'session'), 'The cached permissions requres session middleware to be installed, ' \ | ||
| 'and come before the message middleware in the MIDDLEWARE list' | ||
| cache_key = f'fperms_is_core-{request.user.pk}-{request.session.session_key}' | ||
| cache = caches[settings.IS_CORE_PERM_CACHE_NAME] |
There was a problem hiding this comment.
don't you set it already on line 51? what is the difference? 🤔 also unlike the get_cache function, this doesn't check whether the setting exists
There was a problem hiding this comment.
yes this is wrong :)
| perm_slugs = None | ||
|
|
||
| if cache: | ||
| perm_slugs = cache.get(cache_key) |
There was a problem hiding this comment.
can't you move this inside the first if cache: and perm_slugs = None before it?
matllubos
force-pushed
the
CachePermissions
branch
from
8323ab5
to
4885ac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.