Faster and bullet proof test runner #8
Conversation
matllubos
force-pushed
the
FasterTestRunner
branch
from
ccc5d7b
to
96aeea2
Compare
| @@ -4,17 +4,16 @@ | |||
| from django.db import connections | |||
| from django.test.runner import ParallelTestSuite, DiscoverRunner | |||
|
|
|||
| from germanium.signals import set_up, tear_down | |||
|
|
|||
| from .connection import TestTableConnection | |||
| from .models import dynamodb_model_classes | |||
|
|
|||
|
|
|||
| def init_pynamodb_test_prefix(prefix=None): | |||
| for model_class in dynamodb_model_classes: | |||
| model_class._connection = None | |||
There was a problem hiding this comment.
for other reviewers, this line is necessary for the model_class._get_connection()
pydjamodb/test_runner.py
Outdated
| @@ -4,17 +4,16 @@ | |||
| from django.db import connections | |||
| from django.test.runner import ParallelTestSuite, DiscoverRunner | |||
|
|
|||
| from germanium.signals import set_up, tear_down | |||
There was a problem hiding this comment.
You should add germanium to setup.py as it is now required for the library. (not just for the failing tests, although the test app will need a germanium version bump or removal of the dependency as this app will have it on its own)
There was a problem hiding this comment.
no it is not required
use test runner is not mandatory with using pydjamodb
There was a problem hiding this comment.
added try except too support test runner without germanium
matllubos
force-pushed
the
FasterTestRunner
branch
from
96aeea2
to
6061c63
Compare
matllubos
force-pushed
the
FasterTestRunner
branch
from
6061c63
to
b18f702
Compare
Pull Request Test Coverage Report for Build 1635013183Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
No description provided.