Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use media-container div on images and video #4

Open
elisementor opened this issue May 4, 2017 · 0 comments
Open

use media-container div on images and video #4

elisementor opened this issue May 4, 2017 · 0 comments

Comments

@elisementor
Copy link

elisementor commented May 4, 2017

in panel 2 and panel 4, the right sides are a little too large and the images inside them are also too large
the left hand div doesn't need to be a flex container
the right hand div does need to be a flex column as you have it
the info-box divs within them are flex container rows, as you have them
if you put their images inside a media-container div, they will resize well and look more precisely like the wireframes

.media-container {
overflow: hidden;
}

.media-container img,
.media-container video {
display: block;
width: 100%;
}

sample code for the 35-65 split of the info-box class

/* Universal Component - Content Image Box */

.info-box {
display: flex;
padding: 1rem 0 1rem 1rem;
border-bottom: 1px solid rgb(245, 245, 245);
}

.info-box .media-container {
width: 35%;
}

.info-box .text-content {
display: flex;
flex-direction: column;
justify-content: center;
width: 65%;
padding: 0 0.75rem 0 1rem;
}

https://github.com/drum-IT/colmar/blob/master/index.html#L44

and

https://github.com/drum-IT/colmar/blob/master/resources/css/style.css#L124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant