Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Drupal 10. (#1) #616

Closed
wants to merge 1 commit into from
Closed

Updated to Drupal 10. (#1) #616

wants to merge 1 commit into from

Conversation

AlexSkrypnyk
Copy link
Collaborator

PR against 9.x as there is no 10.x yet. Happy to update to 10.x once it is created.

@@ -13,7 +13,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-versions: ['7.4', '8.1']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D10 requires 8.1 minimum

@@ -40,7 +40,8 @@
"composer/installers": true,
"cweagans/composer-patches": true,
"drupal/core-composer-scaffold": true,
"dealerdirect/phpcodesniffer-composer-installer": true
"dealerdirect/phpcodesniffer-composer-installer": true,
"phpstan/extension-installer": true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpstan/extension-installer comes from drupal/core-dev@^10

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably create a 10x branch here

@webflo
Copy link
Member

webflo commented Oct 6, 2022

Looks, great. Thanks!

@webflo
Copy link
Member

webflo commented Oct 6, 2022

Created 10.x with the commit from @AlexSkrypnyk.

@webflo webflo closed this Oct 6, 2022
@AlexSkrypnyk
Copy link
Collaborator Author

@webflo @leymannx
Thank you for your prompt review and actioning this. 🙏
You've unblock a lot of people trying to push the Drupal 10 contrib updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants