[#660] Fixed required Composer version constraint and added a CI job. #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSkrypnyk
added
D10
PR: Needs review
AlexSkrypnyk
commented
May 16, 2024
| @@ -85,3 +85,26 @@ jobs: | |||
|
|
|||
| - name: Run a single unit test to verify the testing setup | |||
| run: ./vendor/bin/phpunit -c ./web/core ./web/core/modules/user/tests/src/Unit/UserAccessControlHandlerTest.php | |||
|
|
|||
| # Using outdated Composer version to test the Composer version constraint. | |||
| test-composer: | |||
There was a problem hiding this comment.
there is no simple way to use existing jobs without adding a lot of if to every step as this check happens early in the run.
instead, having a standalone (fast) job is easier to maintain.
I called this test-composer rather than test-composer-fail etc. in case we want to add more composer-related tests in the future.
But happy to change the name to anything else.
AlexSkrypnyk
commented
May 16, 2024
| @@ -92,8 +92,8 @@ public static function checkComposerVersion(Event $event) { | |||
| if ($version === '@package_version@' || $version === '@package_branch_alias_version@') { | |||
| $io->writeError('<warning>You are running a development version of Composer. If you experience problems, please update Composer to the latest stable version.</warning>'); | |||
| } | |||
| elseif (Comparator::lessThan($version, '1.0.0')) { | |||
| $io->writeError('<error>Drupal-project requires Composer version 1.0.0 or higher. Please update your Composer before continuing</error>.'); | |||
| elseif (Comparator::lessThan($version, '2.3.6')) { | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#660
stableComposer channelOnce this is approved - I will create a PR for
11.x