Add an 'initial' element to the Drupal Scaffold 'extras' section #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allow files to be scaffolded iff the target file does not yet exist (e.g. to copy from a default file to the user-customized file on first install only).
|
@webflo: Any objections or requests for this? |
|
Merging. |
|
Hmm, this trigger a new tag on Packagist https://packagist.org/packages/drupal-composer/drupal-scaffold#999.0.1464132628 :/. Pinged @derhasi to fix it |
|
A failed build left that tag sitting around in my repository, and I accidentally pushed it with --tags. I deleted the tag from github right away, but I guess Packagist held on to the reference. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow files to be scaffolded iff the target file does not yet exist (e.g. to copy from a default file to the user-customized file on first install only).
One important example of this is the settings.php file. In drops-8, Pantheon supplies an initial settings.php file; of course, Drupal makes this file read-only during the installation process. We want to be able to scaffold the settings.php file on the initial run, but on subsequent runs it would cause an error if we attempted to copy over this file. Using the 'initial' files list introduced in this PR achieves this goal.