-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for composer 2 #34
Conversation
Tagging composer/composer#8726 |
Only the test on PHP 5.4 failed. The error seems like a random composer issue. In any case, I don't know if we should worry too much about PHP 5.4. |
The right thing to do (short of fixing the PHP 5.4 failure) would be to make a new major release that supports Composer 2 and drops support for PHP 5.4 there. |
@greg-1-anderson, I'm guessing that this was a random issue and want to retry the job. I don't think the change itself has anything to do with the failure on PHP 5.4. As for the change: since this only adds support for composer 2, I don't think we need a major release just for this reason. I agree that if we were to drop support for PHP 5.4, we would need a major release but I don't think that's related to this change. |
I'm not a maintainer here, so I can't retry the job, but you're right -- php 5.3 and php 5.5 worked, so the 5.4 failure was probably transient. Try pushing a no-op commit to make all the tests rerun. |
@greg-1-anderson, my bad. I have pushed an empty commit to see what happens. |
Getting an error on
|
Added PR here: hussainweb#1 |
Please see #36. |
Composer2 compatibility. PackageEvents update.
Thanks, @greg-1-anderson. This got lost in things but I have now merged that PR. |
I have a couple additional insignificant changes in #36 that I would still recommend. It would be less confusing if you closed here. If you prefer to keep working here, please merge in my changes & I will close my PR. |
@greg-1-anderson, my availability isn't great for a few days/weeks and would rather close if you're going to take over. Thanks for your work here. |
I couldn't run tests locally due to PHP version conflict but I'm hoping Travis will give meaningful results.