Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(metatag): Add metatag documentation #619

Merged
merged 3 commits into from
Jun 14, 2018
Merged

docs(metatag): Add metatag documentation #619

merged 3 commits into from
Jun 14, 2018

Conversation

joaogarin
Copy link
Member

@joaogarin joaogarin commented Jun 9, 2018

Added some documentation about my experience trying out metatag module. I did run into #609. I then found the GraphQL Metatag which worked well for me and seems like the easiest way to get started on it.

Even though metatag is another contrib, its probably going to be a common scenario people run into and worth documenting the use case.

Not sure if this should be targeting 8.x-3.x or the documentation branch, if that one's still alive

@codecov
Copy link

codecov bot commented Jun 9, 2018

Codecov Report

Merging #619 into 8.x-3.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           8.x-3.x     #619      +/-   ##
===========================================
- Coverage    79.11%   79.09%   -0.02%     
===========================================
  Files          187      187              
  Lines         2949     2947       -2     
===========================================
- Hits          2333     2331       -2     
  Misses         616      616
Impacted Files Coverage Δ
src/Config/GraphQLConfigOverrides.php 87.5% <0%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8445d04...b185240. Read the comment docs.

@joaogarin joaogarin requested a review from fubhy June 12, 2018 13:47
@joaogarin
Copy link
Member Author

Actually while talking on the slack channel found that there is an issue with the graphql_metatag module integration . I think the PR though still makse sense, but just something to keep in mind :

query findJob($slug: String!) {
    route(path: $slug) {
      ... on EntityCanonicalUrl {
        entity {
          entityLabel
          entityMetatags {
            key
            value
          }
        }
      }
    }
  } 

returns an internal server error as an anonymous user.

@fubhy fubhy merged commit a00569d into drupal-graphql:8.x-3.x Jun 14, 2018
@fubhy
Copy link
Contributor

fubhy commented Jun 14, 2018

Cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants