Issue #2645458 by smaz, kmoll: update render trait to handle #item_at… #210
Conversation
…tributes array element that image_formatter expects
|
Would this be more appropriate to do in ImageFieldFormatter? |
|
@davereid I would think that might be a better idea. I am still a little confused why the ImageFieldFormatter uses #item_attributes over #attributes. It seems to be the only place where this is the case. I think if its possible, we update that. If there are good reasons why its that way, then we would have to handle here, I think. Let me know your thoughts. |
|
The core image field formatters require #item_attributes to be set, which is strange, but there's not much we can do about that from Entity Embed's side of things, we can only ensure the correct values are set. |
|
Unfortunately we can't move this as we add align, caption, ... classes after formatter plugin has returned the render array. Looking at test fails now. |
|
Attempt to fix test: https://www.drupal.org/node/2645458#comment-11117123 |
|
Closing as this was fixed via Drupal.org |
…tributes array element that image_formatter expects