This repository has been archived by the owner on Jan 5, 2018. It is now read-only.
Adds EntityEmbedPostRenderCache service class. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Drupal 8 core must have a current patch from https://drupal.org/node/2217877 | ||
| applied. | ||
| * Drupal 8 core must have a current patch from | ||
| https://drupal.org/project/2247779 applied. |
There was a problem hiding this comment.
should be https://drupal.org/node/2247779 :)
There was a problem hiding this comment.
Thanks!
Dave Reid
dave@davereid.net | http://www.davereid.net/ | 402-431-2412
On Tue, Jun 10, 2014 at 2:09 PM, Jibran Ijaz notifications@github.com
wrote:
In README.md:
@@ -2,8 +2,8 @@
Requirements
-* Drupal 8 core must have a current patch from https://drupal.org/node/2217877
- applied.
+* Drupal 8 core must have a current patch from- https://drupal.org/project/2247779 applied.
should be https://drupal.org/node/2247779 :)
—
Reply to this email directly or view it on GitHub
https://github.com/drupal-media/entity_embed/pull/38/files#r13612923.
|
We can hold off on this for now I think, but like the previous core patch, we'll have to be using this anyway at some point, so we might as well merge it sometime in the near future as well. |
Conflicts: entity_embed.services.yml
Conflicts: README.md
davereid
added a commit
that referenced
this pull request
Jun 14, 2014
…-service Added an EntityEmbedPostRenderCache service class in response to https://drupal.org/project/2247779 committed to core.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on the core patch from https://drupal.org/project/2247779.