Slideshow media bundle #6
Conversation
vijaynandwani
force-pushed
the
master
branch
2 times, most recently
from
83ffcbc
to
3fead67
Compare
|
|
||
| You can use the slick library to improve the gallery display. | ||
|
|
||
| 1) Download [Slick Library](https://github.com/kenwheeler/slick/) and extract it in libraries directory. Required assets should be available at /libraries/slick/slick/slick.css |
There was a problem hiding this comment.
It would be great to include this in the module by default.
There was a problem hiding this comment.
Okay. I'll mention the required libraries as a requirement for the module. And should we include the slick extras module too or mention in the readme for extra styles. https://www.drupal.org/project/slick_extras
There was a problem hiding this comment.
I would provide a minimal working configuration with as little dependencies as possible (probably just the slick and slick_media modules) and export that.
vijaynandwani
force-pushed
the
master
branch
2 times, most recently
from
8804ac1
to
ca5307c
Compare
| optionset_thumbnail: '' | ||
| skin: '' | ||
| skin_thumbnail: '' | ||
| image_style: slick_media |
There was a problem hiding this comment.
Do we have to call this image style "slick_media". I would expect something that would suggest a gallery item.
There was a problem hiding this comment.
Also provide a new "Gallery item" View mode for both "Image" and "Video" and configure it to only display the media item with our image style.
|
I'm afraid you'll have to take care of installing all the dependencies in the 'before' script othwerwise the test won't pass, because media won't install. |
|
@paranojik dependencies are being installed. Tests are passing. There is still some problem with schema defined incorrectly but I have already opened an issue for that. |
|
Even though I have added our own image style, it is not being used because of the vanilla value being true. You should review it once again to see if we actually need our own image style or not. |
|
what vanilla value are you referring to? we do need our own style because
|
|
@paranojik Yeah that's right. I have made new image style without any effect for gallery items. You can review it now. |
| @ToDo | ||
| 1. Enable the module | ||
| 2. visit /media/add to add media content to website. | ||
| 3. Visit /admin/structure/media to edit the default media bundles. | ||
|
|
There was a problem hiding this comment.
You forgot to transfer the installation instructions from the Media library PR.
There was a problem hiding this comment.
No i didn't. We have included slick module in dependency so those instructions are useless now. I'll remove them from media library PR
No description provided.