This repository has been archived by the owner on Jan 5, 2018. It is now read-only.
Ckeditor integration #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: I also checked it - Admin tests are passing locally |
|
Cool, the tests are all passing now. Weird why the AdminTest failed earlier. |
| } | ||
| } | ||
|
|
||
| //var entity_label = data.label ? data.label : existingValues['data-entity-label']; |
|
I don't know whats up with Travis, its showing random errors on builds and the errors change when I rebuild it. |
prateekmehta
force-pushed
the
Ckeditor_Integration
branch
from
92b2576
to
c710eb1
Compare
|
@davereid Could you also please review it, so i can move forward with filed formatter. |
|
@prateekmehta The field formatter can be done completely independently of any of this work, please do not let it hold you up. |
|
It would be nice to get a rebase on all of these commits. |
|
@davereid Seems like they already are rebased. |
|
Grr, Github not updating. Thanks, I see that now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Preview Test