Add a ConfigUpdater service #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglaman
force-pushed
the
config-update-servicer
branch
9 times, most recently
from
2a03c19
to
231656e
Compare
|
@bojanz ready for review :) and proper commit name suggestion |
mglaman
force-pushed
the
config-update-servicer
branch
from
231656e
to
3e3ffe2
Compare
| @@ -0,0 +1,53 @@ | |||
| <?php | |||
| /** | |||
| * Created by PhpStorm. | |||
There was a problem hiding this comment.
This docblock needs to go :)
| @@ -34,6 +34,10 @@ services: | |||
| tags: | |||
| - { name: service_collector, tag: commerce.availability_checker, call: addChecker } | |||
|
|
|||
| commerce.config_update: | |||
There was a problem hiding this comment.
If the name of the class is ConfigUpdater, then the service name should match, commerce.config_updater
| public function delete(array $config_names); | ||
|
|
||
| /** | ||
| * Gets the current active value of configuration. |
There was a problem hiding this comment.
s/Gets/Loads, so that the verb matches the method name.
|
Looks almost ready. Great job! |
mglaman
force-pushed
the
config-update-servicer
branch
4 times, most recently
from
74fb1c8
to
0304edc
Compare
|
@bojanz all items addressed |
mglaman
force-pushed
the
config-update-servicer
branch
3 times, most recently
from
e18c9cd
to
4af7656
Compare
Because hook_update_N + config == hard.
mglaman
force-pushed
the
config-update-servicer
branch
from
4af7656
to
7f9cf74
Compare
| $type = $this->getConfigType($config_name); | ||
| if ($type == 'system.simple') { | ||
| $config = $this->configFactory->getEditable($config_name); | ||
| if (!$config) { |
There was a problem hiding this comment.
getEditable() always returns a config object, so the if (!$config) will never work. Furthermore, we already checked active storage above.
|
Addressed most of the feedback above, committed in af4e4bb. Followup:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because hook_update_N + config == hard.