2603482 order language behavior #352
Open
+139
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getter setter for the language
modules/cart/src/CartManager.php
Outdated
| @@ -56,6 +64,7 @@ public function __construct(EntityTypeManagerInterface $entity_type_manager, Lin | |||
| $this->lineItemStorage = $entity_type_manager->getStorage('commerce_line_item'); | |||
| $this->lineItemMatcher = $line_item_matcher; | |||
| $this->eventDispatcher = $event_dispatcher; | |||
| $this->languageManager = \Drupal::languageManager(); | |||
There was a problem hiding this comment.
Update services.yml to inject this into the service. Update create method to get it from service, make it an argument.
|
Hi @mglaman, I have updated the code. Regards |
haringsrob
force-pushed
the
2603482-order-language-behavior
branch
from
65e29ab
to
5830fc3
Compare
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
0720d3a
to
821711d
Compare
bojanz
force-pushed
the
8.x-2.x
branch
3 times, most recently
from
ae8f1aa
to
b40d0af
Compare
modules/cart/src/CartManager.php
Outdated
| // If the language is different, we need to save it again. If we are already | ||
| // planning to trigger the save, there is no need to do the additional | ||
| // checks. | ||
| if (!$needs_cart_save && $cart->getLanguage()->getId() <> $this->languageManager->getCurrentLanguage()->getId()) { |
There was a problem hiding this comment.
I don't see any usage of <> in the php code, I think this should be replaced by !==
bojanz
force-pushed
the
8.x-2.x
branch
5 times, most recently
from
424752f
to
b5cc4b2
Compare
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
c89efa0
to
3944b06
Compare
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
c54a308
to
85d9f2e
Compare
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
f72b292
to
2503a92
Compare
bojanz
force-pushed
the
8.x-2.x
branch
3 times, most recently
from
5a36359
to
6602c62
Compare
|
This needs a re-roll, then we can do an updated review. |
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
68e6e5f
to
ac287b7
Compare
haringsrob
force-pushed
the
2603482-order-language-behavior
branch
from
3f9b894
to
41b705b
Compare
…-order-language-behavior
haringsrob
force-pushed
the
2603482-order-language-behavior
branch
from
41b705b
to
a64f773
Compare
|
I have updated the comments and rerolled onto latest 8.x |
bojanz
force-pushed
the
8.x-2.x
branch
7 times, most recently
from
6be1d5c
to
b8a7444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have made an attempt for the implementation that has the following requirements: