Issue #2794485 - Remove EntityStoreInterface, add EntityStoresInterface #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface, and EntityStoresInterface with the right methods, used by products and promotions.
miteshmap
force-pushed
the
2794485-replace-entitystoreinterface-entitystoresinterface
branch
from
cc0e7d2
to
2ce598b
Compare
|
@miteshmap I don't see modifications to promotion entity? |
|
@mgalang missed it. I Will work on it. |
|
@miteshmap cool, once rebased w/ change want to remove "needs work" label to "review" |
|
Finished and committed in 923d672. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed EntityStoreInterface, moved the relevant methods to OrderInterface, and EntityStoresInterface with the right methods, used by products and promotions.
Ref - https://www.drupal.org/node/2794485