Issue #2656818 by vasike, smccabe, bojanz: Implement optimistic locking for orders #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglaman
reviewed
Feb 27, 2017
modules/cart/commerce_cart.module
Outdated
| function commerce_cart_commerce_cart_form_validate($form, FormStateInterface $form_state) { | ||
| // Re-load the order. | ||
| /** @var \Drupal\commerce_order\Entity\OrderInterface $order */ | ||
| $order = Order::load($form_state->get('order_id')); |
There was a problem hiding this comment.
Should we use loadUnchanged from storage to ensure it's fresh?
modules/cart/commerce_cart.module
Outdated
| @@ -138,6 +188,10 @@ function commerce_cart_form_commerce_order_form_alter(array &$form, FormStateInt | |||
| // Move the cart element to the bottom of the meta sidebar container. | |||
| $form['cart']['#group'] = 'meta'; | |||
| $form['cart']['#weight'] = 100; | |||
| // Warning it the order is cart and it was modified in the last hour. | |||
| if (!empty($order->get('cart')->value) && (REQUEST_TIME - $order->getChangedTime()) < 3600) { | |||
There was a problem hiding this comment.
i did intentionally as i think soon we'll switch to 8.3 and use core time.
however i'll switch to Commerce Time till then. thanks
| /** | ||
| * Exception interface for all exceptions thrown by the Order module. | ||
| */ | ||
| interface ExceptionInterface {} |
| @@ -61,6 +61,11 @@ public function form(array $form, FormStateInterface $form_state) { | |||
| '#type' => 'hidden', | |||
| '#default_value' => $order->getChangedTime(), | |||
| ]; | |||
| // Version must be sent to the client, for later overwrite error checking. | |||
| $form['version'] = [ | |||
| '#type' => 'hidden', | |||
There was a problem hiding this comment.
it seems it won't work with value. we need to send it to client.
…o 2656818-order-locking
…o 2656818-order-locking
…o 2656818-order-locking
…o 2656818-order-locking
…o 2656818-order-locking
…o 2656818-order-locking
…view has the order id argument.
bojanz
force-pushed
the
8.x-2.x
branch
7 times, most recently
from
6be1d5c
to
b8a7444
Compare
…o 2656818-order-locking
…o 2656818-order-locking
|
An updated patch is being posted to the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.