Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2855815: Add custom coupon storage, provide loadByCode method. #653

Merged
merged 1 commit into from Feb 27, 2017
Merged

Issue #2855815: Add custom coupon storage, provide loadByCode method. #653

merged 1 commit into from Feb 27, 2017

Conversation

mitrpaka
Copy link
Contributor

No description provided.

mglaman
mglaman requested changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We also need a test

modules/promotion/src/CouponStorage.php Outdated
/**
* {@inheritdoc}
*/
public function loadByCode($coupon_code) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just change the parameter to code

@mglaman
Copy link
Contributor

mglaman commented Feb 27, 2017

I made the change and added test.

@mglaman mglaman merged commit 7ca6964 into drupalcommerce:8.x-2.x Feb 27, 2017
@mglaman mglaman mentioned this pull request Feb 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglaman mglaman mglaman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mitrpaka @mglaman