Issue #2861664 by mglaman: Order assignment should generate a log to … #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed because of phpcs: |
bojanz
reviewed
Mar 20, 2017
| @@ -34,6 +36,7 @@ public static function getSubscribedEvents() { | |||
| 'commerce_order.validate.pre_transition' => ['onValidateTransition', -100], | |||
| 'commerce_order.fulfill.pre_transition' => ['onFulfillTransition', -100], | |||
| 'commerce_order.cancel.pre_transition' => ['onCancelTransition', -100], | |||
| OrderEvents::ORDER_ASSIGN => ['onOrderAssign', -100], | |||
There was a problem hiding this comment.
We don't use constants above, so let's not use it here either, to stay consistent.
Core generally discourages constants and recommends the real IDs to be used.
There was a problem hiding this comment.
We don't above because they don't exist. And that seems silly if core recommends real IDs yet constants provided. I'll change to keep it consistent here.
bojanz
reviewed
Mar 20, 2017
| * Tests that an order assignment log is generated. | ||
| */ | ||
| public function testOrderAssignedLog() { | ||
| // Reassignment does not work on users |
There was a problem hiding this comment.
The comment is confusing (doesn't work - why?). I suggest "Reassignment is currently only done on user login."
bojanz
force-pushed
the
8.x-2.x
branch
5 times, most recently
from
1028fc1
to
005e904
Compare
…mark the customer conversion
mglaman
force-pushed
the
2861664-order-assignment-event
branch
from
d0f4e89
to
c060cf9
Compare
bradjones1
pushed a commit
to bradjones1/commerce
that referenced
this pull request
May 4, 2017
…mark the customer conversion (drupalcommerce#680)
nikathone
pushed a commit
to nikathone/commerce
that referenced
this pull request
Feb 2, 2018
…mark the customer conversion (drupalcommerce#680)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mark the customer conversion