issue #2859834 implementation of links in checkout progress block #686
Conversation
…thub.com:finnef/commerce into 2859834-checkout-progress-link-to-previous-steps
|
We also need a setting for enabling this, like the D7 module had. |
| $label = Link::createFromRoute($step_definition['label'], 'commerce_checkout.form', [ | ||
| 'commerce_order' => $order->id(), | ||
| 'step' => $step_id, | ||
| ])->toString(); |
There was a problem hiding this comment.
maybe ->to Renderable() will be better here ?
There was a problem hiding this comment.
Should always be renderable, unless that does fail
| $label = Link::createFromRoute($step_definition['label'], 'commerce_checkout.form', [ | ||
| 'commerce_order' => $order->id(), | ||
| 'step' => $step_id, | ||
| ])->toString(); |
There was a problem hiding this comment.
Should always be renderable, unless that does fail
| @@ -14,6 +14,6 @@ | |||
| #} | |||
| <ol class="checkout-progress clearfix"> | |||
| {% for step in steps %} | |||
| <li class="checkout-progress--step checkout-progress--step__{{ step.position }}">{{ step.label }}</li> | |||
| <li class="checkout-progress--step checkout-progress--step__{{ step.position }}">{{ step.label | raw }}</li> | |||
There was a problem hiding this comment.
If we remove raw toRenderable should be fine
|
changed to Renderable() and removed | raw. |
There was a problem hiding this comment.
1)
Drupal\Tests\commerce_checkout\Kernel\ChainCheckoutFlowResolverTest::testCheckoutFlowResolution
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for
commerce_checkout.commerce_checkout_flow.default with the following errors:
commerce_checkout.commerce_checkout_flow.default:configuration.display_checkout_progress_breadcrumb_links
missing schema
the new option needs to be added to the module's schema.
can we also update a test where it clicks a link and goes back and continues?
|
Added tests and schema. |
| @@ -155,13 +166,14 @@ public function testRegisterOrderCheckout() { | |||
| 'login[register][password][pass2]' => 'pass', | |||
| ], 'Create account and continue'); | |||
| $this->assertSession()->pageTextContains('Billing information'); | |||
| // Check breadcrumbs are not links. (the default setting) | |||
| $this->assertSession()->elementNotExists('css', '.block-commerce-checkout-progress li.checkout-progress--step > a'); | |||
There was a problem hiding this comment.
So we assert it's not a link, however we do not prove the feature works in any test
There was a problem hiding this comment.
The test to use the link to move back and fwd through the checkout steps is in testGuestOrderCheckout. The test for no link (by default) is in testRegisterOrderCheckout.
There was a problem hiding this comment.
Oh duh, wow i totally missed that. All good then!
bojanz
force-pushed
the
8.x-2.x
branch
7 times, most recently
from
6be1d5c
to
b8a7444
Compare
|
Continued (rebased) in #732. |
No description provided.