Commerce profile select reuse combined #715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest changes from commerce
Upstream updates
Closed
bojanz
force-pushed
the
8.x-2.x
branch
5 times, most recently
from
1028fc1
to
005e904
Compare
|
Latest updates work with the latest version of commerce. Also revamps much of the ProfileSelect code from the previous patches into something that I think is a little bit more manageable. Feedback needed. |
|
Closing this. Matt is making big changes to the profile reuse PR, which will require the profile copy PR to be rebased. We couldn't do both at the same time because just the reuse PR has a huge scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the other PR I just submitted, #714, as well as to #631.
This is a combined PR containing both the profile reuse functionality from #714 as well as the profile select functionality from #631, since this requires a number of changes for them to both be able to apply together.
Obviously, one could be merged first, and then the other patch modified to support it, but it seemed simpler to tackle them together because they share some of the same functionality.