Issue #2874149: Add tax number field and validation. #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds (built on prior work) a tax number field and tax type based validation handling to commerce_tax. Basic validation for EU countries via VIES (online service to verify vat numbers) is implemented.
Generally this should be extensible for other tax types (as the number validation will always be coupled to these entities) and could be further enhanced.
Currently all Tax numbers from countries outside of the EU will be be denied as they can't be verified.
I would be gateful for feedback on this patch (as my experience is very limited in this regard).