Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed URL getting library #176

Closed
aangelinsf opened this issue May 26, 2015 · 9 comments
Closed

Malformed URL getting library #176

aangelinsf opened this issue May 26, 2015 · 9 comments

Comments

@aangelinsf
Copy link

Sometime over the weekend Bootswatch API starting returning https: for its urls. In template.php, that breaks the following:
drupal_add_css($base['scheme'] . ":" . $css, 'external');

A workaround for me is:
if (strpos($css, 'http') <> 0) {
drupal_add_css($base['scheme'] . ":" . $css, 'external');
}
else {
drupal_add_css($css, 'external');
}

@pirog
Copy link
Contributor

pirog commented May 27, 2015

Nice! great to know.

@labboy0276 @soniktrooth maybe one of you guys can hit up a quick PR for this?

@reynoldsalec
Copy link
Contributor

Just confirming that other folks have had this issue and that a quick fix would be nice to allay the pain.

@soniktrooth
Copy link
Contributor

@reynoldsalec @pirog I will look into it this afternoon.

amandavisconti pushed a commit to amandavisconti/infinite-ulysses-dissertation that referenced this issue May 27, 2015
The site CSS became subtly messed up (header disjointed, missing
padding, etc.) at some point over last weekend. The culprit turned out
to be a change in the Bootswatch API (see Kalatheme GitHub repo issue:
drupalprojects/kalatheme#176).
soniktrooth pushed a commit that referenced this issue May 27, 2015
@pirog
Copy link
Contributor

pirog commented May 30, 2015

I think @soniktrooth has dealt his judgement unto this issue and its fixed in dev now.

@pirog pirog closed this as completed May 30, 2015
@gboudrias
Copy link

I think this stll needs to be fixed in 4.x

@pirog
Copy link
Contributor

pirog commented Jun 22, 2015

@soniktrooth? i thought you merged this into 4.x as well? maybe im thinking of something else such as how awesome taylor swift is?

@soniktrooth
Copy link
Contributor

I thought it was as well. You keep thinking about TS and I'll track down what happened.

@soniktrooth
Copy link
Contributor

Sorry @gboudrias it looks like there's something up with hubdrop so this never got pushed to drupal.org. This commit (62fa410) was merged here already but needed a little extra help to make it onto d.o. It should be up there now.

@gboudrias
Copy link

Awesome, keep up the great work guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants