Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font awesome and bootstrap for 3.0 release #78

Closed
pirog opened this issue Jun 29, 2014 · 7 comments
Closed

Update font awesome and bootstrap for 3.0 release #78

pirog opened this issue Jun 29, 2014 · 7 comments
Assignees
Milestone

Comments

@pirog
Copy link
Contributor

pirog commented Jun 29, 2014

We want to upgrade to the latest bootstrap and font awesome for 3.x.

You might want to look at the following issues from 4.x to help.
#65
#45

@pirog pirog added the 7.x-3.x label Jun 29, 2014
@pirog pirog added this to the 7.x-3.0 Release milestone Jun 29, 2014
@labboy0276
Copy link

@pirog I updated the CDN calls to the latest version on each. It seems 4.x uses a who different approach with font-awesome. Did you want that functionality in 3.x?

@pirog
Copy link
Contributor Author

pirog commented Jun 30, 2014

Do you mean 4.1x? We are already using 4.x for FA.

@labboy0276
Copy link

oh no i mean kalatheme 4.x

#61

that whole grunt function

@pirog
Copy link
Contributor Author

pirog commented Jun 30, 2014

Got it. No i just wanted to update to the latest versions. Do they seem to cause any errors?

@labboy0276
Copy link

I tested locally with no problems, I will test other places and see, but it should be ok

@pirog
Copy link
Contributor Author

pirog commented Jun 30, 2014

yeah do a quick pass and then let me know. i would create a new subtheme
with FA and see if the thumbs up icon shows up in the status message that
says "looking good" or some such.

On Mon, Jun 30, 2014 at 10:26 AM, John Ouellet notifications@github.com
wrote:

I tested locally with no problems, I will test other places and see, but
it should be ok


Reply to this email directly or view it on GitHub
#78 (comment)
.

Cheers,

Mike Pirog
Kalamuna
www.kalamuna.com

@labboy0276
Copy link

All set I generated a site locally and one pantheon, tested the new font awesome 4.1 incon and it worked

pirog added a commit that referenced this issue Jul 1, 2014
Issue #78 Updated bootstrap and font awesome cdn
@pirog pirog closed this as completed Jul 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants