pm:security passes on 9 (#4239)

* pm:security passes with drupal 9

* Re-enable pm:security test for Drupal 9

* Keep alinks for pm:security

.circleci/config.yml

@@ -126,7 +126,6 @@ jobs:
       - run: cp .docker/zz-php.ini /usr/local/etc/php/conf.d/
       - run: composer remove --dev webflo/drupal-core-strict --no-update
       - run: composer remove --dev webflo/drupal-core-require-dev --no-update
-      - run: composer remove --dev drupal/alinks --no-update
       - run: composer require --dev drupal/core:9.0.x-dev --no-update
       - run: composer config platform.php 7.2.3
       - run: composer update --no-scripts

build/scripts/publish-api-docs.sh

@@ -45,5 +45,6 @@ echo "Commit new API docs."
 # Commit any changes to the documentation
 cd "$API_BUILD_DIR"
 git add -A api
-git commit -m "Update API documentation from Travis build $TRAVIS_BUILD_NUMBER, '$TRAVIS_COMMIT'."
+# Sometimes there is nothing to commit so ignore return value.
+git commit -m "Update API documentation from Travis build $TRAVIS_BUILD_NUMBER, '$TRAVIS_COMMIT'." || true
 git push

tests/integration/SecurityUpdatesTest.php

@@ -15,12 +15,7 @@ class SecurityUpdatesTest extends UnishIntegrationTestCase
    */
     public function testInsecurePackage()
     {
-        // TODO: re-enable this test once the pm:security command is
-        // compatible with Drupal 9.
-        if ($this->isDrupalGreaterThanOrEqualTo('9')) {
-            $this->markTestSkipped('pm:security not working on Drupal 9 yet.');
-        }
-
+        // @todo This passes on Drupal because drupal/alinks has a security release for 8 and we don't actually install that module on our d9 tests.
         $this->drush('pm:security', [], ['format' => 'json'], self::EXIT_ERROR);
         $this->assertContains('One or more of your dependencies has an outstanding security update.', $this->getErrorOutput());
         $this->assertContains('Try running: composer require drupal/alinks', $this->getErrorOutput());