PHP 8.2 compatibility

[andypost]

Upcoming release https://wiki.php.net/todo/php82 already started to publish releases

There's few incompatibilities detected so let's collect them under this issue

On July 21 first beta will be published but some changes already could be caught

• https://php.watch/versions/8.2/$%7Bvar%7D-string-interpolation-deprecated
• https://php.watch/versions/8.2/partially-supported-callable-deprecation
• https://php.watch/versions/8.2/dynamic-properties-deprecated

PS core's issue is https://www.drupal.org/project/drupal/issues/3283358

[andypost]

There's already fixed webmozarts/assert@af18046

EDIT this dependency needs upgrade to 1.11.0

[weitzman]

I think this is done.

[danshumaker]

I'm getting this error for version 11.5.1

docker@cli:/var/www$ drush --version
Drush Launcher Version: 0.10.1
PHP Deprecated:  Use of "static" in callables is deprecated in phar:///usr/local/bin/drush/vendor/webmozart/assert/src/Assert.php on line 1973

Deprecated: Use of "static" in callables is deprecated in phar:///usr/local/bin/drush/vendor/webmozart/assert/src/Assert.php on line 1973
PHP Deprecated:  Use of "static" in callables is deprecated in phar:///usr/local/bin/drush/vendor/webmozart/assert/src/Assert.php on line 1973

Deprecated: Use of "static" in callables is deprecated in phar:///usr/local/bin/drush/vendor/webmozart/assert/src/Assert.php on line 1973
Drush Commandline Tool 11.5.1

docker@cli:/var/www$ php --version
PHP 8.2.3 (cli) (built: Mar  1 2023 08:20:15) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.3, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.3, Copyright (c), by Zend Technologies
    with blackfire v1.86.4~linux-x64-non_zts82, https://blackfire.io, by Blackfire

So it's fixed but not released? Do I downgrade to get the upgrade? I'm not sure why the versions go from 11.5.1 (latest) to 8.4.12 and then to 12..

[greg-1-anderson]

Drush 8 is the legacy version of Drush, for Drupal 7 support. Drush 8 and Drush 12 support PHP 8.2; looks like Drush 11 does not. You could try one of the RC releases of Drush 12. Drush 12 stable should be released pretty soon.

[danshumaker]

Thank you @greg-1-anderson . I see that when I try 12.0.0-rc4 it does seem to use webmozart/assert version 1.11.0 as mentioned above. However I get these errors after the upgrade:

docker@cli:/var/www$ vendor/bin/drush --version
PHP Fatal error:  Uncaught TypeError: Cannot assign bool to property Drush\Config\Environment::$docPrefix of type ?string in /var/www/vendor/drush/drush/src/Config/Environment.php:290
Stack trace:
#0 /var/www/vendor/drush/drush/src/Config/Environment.php(141): Drush\Config\Environment->docsPath()
#1 /var/www/vendor/drush/drush/src/Config/ConfigLocator.php(200): Drush\Config\Environment->exportConfigData()
#2 /var/www/vendor/drush/drush/src/Preflight/Preflight.php(183): Drush\Config\ConfigLocator->addEnvironment(Object(Drush\Config\Environment))
#3 /var/www/vendor/drush/drush/src/Preflight/Preflight.php(253): Drush\Preflight\Preflight->prepareConfig(Object(Drush\Config\Environment))
#4 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(58): Drush\Preflight\Preflight->preflight(Array)
#5 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 /var/www/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run(Array)
#7 /var/www/vendor/drush/drush/drush(4): require('/var/www/vendor...')
#8 /var/www/vendor/bin/drush(119): include('/var/www/vendor...')
#9 {main}
  thrown in /var/www/vendor/drush/drush/src/Config/Environment.php on line 290

Fatal error: Uncaught TypeError: Cannot assign bool to property Drush\Config\Environment::$docPrefix of type ?string in /var/www/vendor/drush/drush/src/Config/Environment.php:290
Stack trace:
#0 /var/www/vendor/drush/drush/src/Config/Environment.php(141): Drush\Config\Environment->docsPath()
#1 /var/www/vendor/drush/drush/src/Config/ConfigLocator.php(200): Drush\Config\Environment->exportConfigData()
#2 /var/www/vendor/drush/drush/src/Preflight/Preflight.php(183): Drush\Config\ConfigLocator->addEnvironment(Object(Drush\Config\Environment))
#3 /var/www/vendor/drush/drush/src/Preflight/Preflight.php(253): Drush\Preflight\Preflight->prepareConfig(Object(Drush\Config\Environment))
#4 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(58): Drush\Preflight\Preflight->preflight(Array)
#5 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 /var/www/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run(Array)
#7 /var/www/vendor/drush/drush/drush(4): require('/var/www/vendor...')
#8 /var/www/vendor/bin/drush(119): include('/var/www/vendor...')
#9 {main}
  thrown in /var/www/vendor/drush/drush/src/Config/Environment.php on line 290
docker@cli:/var/www$ php --version

Any ideas or suggestions?

[andypost]

can;t reproduce

/var/www/html/web $ vendor/bin/drush --version
Drush Commandline Tool 12.0.0.0
/var/www/html/web $ vendor/bin/drush version
Drush version : 12.0.0.0 
/var/www/html/web $ php -v
PHP 8.2.6 (cli) (built: May 10 2023 09:01:24) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.6, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.6, Copyright (c), by Zend Technologies

[danshumaker]

@andypost Can you start with drush version 11.5.1 , then do a composer update to get version 12 and then run those commands? That's my context. Is there a different upgrade step than a composer install drush/drush:^12 ? I tried restarting the container but that didn't seem to help.

[andypost]

@danshumaker yes, both works for me but use composer req drush/drush ^12.0

[gitressa]

Something also blocked me from upgrading to version 12. So I tried removing and re-installing Drush, which worked well. Drush blocks Composer updates in some situations, where the trick is to remove it temporarily.

[danshumaker]

Cool works now. thx.

[danshumaker]

@greg-1-anderson @andypost Just fyi this might end up causing more problems. We performed the composer update in our repo and when it was deployed to Acquia the container got the drush errors mentioned above.

2023-06-07T13:12:35Z 
2023-06-07T13:12:35Z Fatal error: Uncaught TypeError: Cannot assign bool to property Drush\Config\Environment::$docPrefix of type ?string in /var/www/html/vendor/drush/drush/src/Config/Environment.php:290
2023-06-07T13:12:35Z Stack trace:
2023-06-07T13:12:35Z #0 /var/www/html/vendor/drush/drush/src/Config/Environment.php(141): Drush\Config\Environment->docsPath()
2023-06-07T13:12:35Z #1 /var/www/html/vendor/drush/drush/src/Config/ConfigLocator.php(200): Drush\Config\Environment->exportConfigData()
2023-06-07T13:12:35Z #2 /var/www/html/vendor/drush/drush/src/Preflight/Preflight.php(183): Drush\Config\ConfigLocator->addEnvironment()
2023-06-07T13:12:35Z #3 /var/www/html/vendor/drush/drush/src/Preflight/Preflight.php(253): Drush\Preflight\Preflight->prepareConfig()
2023-06-07T13:12:35Z #4 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(58): Drush\Preflight\Preflight->preflight()
2023-06-07T13:12:35Z #5 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
2023-06-07T13:12:35Z #6 /var/www/html/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run()
2023-06-07T13:12:35Z #7 /var/www/html/vendor/drush/drush/drush(4): require('...')
2023-06-07T13:12:35Z #8 /var/www/html/vendor/bin/drush(120): include('...')
2023-06-07T13:12:35Z #9 {main}
2023-06-07T13:12:35Z   thrown in /var/www/html/vendor/drush/drush/src/Config/Environment.php on line 290

Any suggestions on a fix?

[mohammadzo]

I can replicate this:
Drupal 10.2.x and PHP 8.2 and Latest version of Drush 12.4.3.0 .

$ drush --version 
Drush Launcher Version: 0.10.1

Deprecated: Use of "static" in callables is deprecated in phar:///usr/local/bin/drush/vendor/webmozart/assert/src/Assert.php on line 1973

Deprecated: Use of "static" in callables is deprecated in phar:///usr/local/bin/drush/vendor/webmozart/assert/src/Assert.php on line 1973
Drush Commandline Tool 12.4.3.0