Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump the docker image to PHP 8.2 for the new nginx aggregation rules. #110

Merged
merged 6 commits into from
Jul 27, 2023

Conversation

cafuego
Copy link
Contributor

@cafuego cafuego commented Jul 7, 2023

Those are necessary for Drupal 10.1 sites. Also, no npm stuff, so no need for the unified-builder image anymore.

Refs: OPS-9427 OPS-9423

@cafuego cafuego mentioned this pull request Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.8 (cli) (built: Jul 8 2023 07:10:21) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.8, Copyright (c) Zend Technologies with Zend OPcache v8.2.8, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.5.8 2023-06-09 17:13:21
Drupal Logs

Pusher: @berliner, Action: pull_request, Workflow: Run tests

@berliner
Copy link
Contributor

composer install works fine. But I get warnings for drush commands afterwards:

Deprecated: Use of "static" in callables is deprecated in phar:///usr/local/bin/drush/vendor/webmozart/assert/src/Assert.php on line 1973
<em class="placeholder">Warning</em>: ini_set(): Session ini settings cannot be changed after headers have already been sent in <em class="placeholder">include()</em> (line <em class="placeholder">91</em> of <em class="placeholder">/var/www/html/sites/default/settings.docksal.php</em>). <pre class="backtrace">include(&#039;/var/www/html/sites/default/settings.docksal.php&#039;) (Line: 7)
include(&#039;/var/www/html/sites/default/settings.local.php&#039;) (Line: 818)
require(&#039;/var/www/html/sites/default/settings.php&#039;) (Line: 145)
Drupal\Core\Site\Settings::initialize(&#039;/var/www/html&#039;, &#039;sites/default&#039;, Object) (Line: 225)
Drush\Commands\core\CacheCommands-&gt;rebuild(Array)
call_user_func_array(Array, Array) (Line: 276)
Consolidation\AnnotatedCommand\CommandProcessor-&gt;runCommandCallback(Array, Object) (Line: 212)
Consolidation\AnnotatedCommand\CommandProcessor-&gt;validateRunAndAlter(Array, Array, Object) (Line: 175)
Consolidation\AnnotatedCommand\CommandProcessor-&gt;process(Object, Array, Array, Object) (Line: 387)
Consolidation\AnnotatedCommand\AnnotatedCommand-&gt;execute(Object, Object) (Line: 326)
Symfony\Component\Console\Command\Command-&gt;run(Object, Object) (Line: 1081)
Symfony\Component\Console\Application-&gt;doRunCommand(Object, Object, Object) (Line: 320)
Symfony\Component\Console\Application-&gt;doRun(Object, Object) (Line: 174)
Symfony\Component\Console\Application-&gt;run(Object, Object) (Line: 124)
Drush\Runtime\Runtime-&gt;doRun(Array, Object) (Line: 51)
Drush\Runtime\Runtime-&gt;run(Array) (Line: 79)
require(&#039;/var/www/vendor/drush/drush/drush.php&#039;) (Line: 18)
drush_main() (Line: 143)
require(&#039;phar:///usr/local/bin/drush/bin/drush.php&#039;) (Line: 14)

Updating to drush 12 helps, but keeps the deprecation warnings for some reason.

@berliner
Copy link
Contributor

berliner commented Jul 10, 2023

I'm getting an issue with drush 12 though when running our update commands: The "--no-post-updates" option does not exist. It got removed in drush-ops/drush#4494 and we should now use the deploy command.

@cafuego
Copy link
Contributor Author

cafuego commented Jul 17, 2023

Hah! Ok, I have a PR for Jenkins to fix that - https://github.com/UN-OCHA/tools-jenkins-jobs/pull/31

The hpc-content-dev-deploy task will use that branch with the updates deploy command. If that works as expected, I can merge it into main, which will make all other envs and sites use it, too.

Worked fine for Sesame - https://jenkins.aws.ahconu.org/view/Sesame/job/sesame-dev-deploy/130/console

@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 15.42% ( 177 / 1148 )
Methods: 21.14% ( 26 / 123 )
Lines: 14.73% ( 151 / 1025 )

@berliner berliner merged commit 6107fa9 into update/patch-e5852f6 Jul 27, 2023
2 checks passed
@berliner berliner deleted the cafuego/php-82 branch July 27, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants