Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically set the label-separator so it matches the list-separator when CSV is detected #52

Closed
greg-1-anderson opened this issue Sep 1, 2013 · 4 comments
Closed

Automatically set the label-separator so it matches the list-separator when CSV is detected #52

greg-1-anderson opened this issue Sep 1, 2013 · 4 comments
Assignees
@greg-1-anderson

Comments

@greg-1-anderson
Copy link
Member

Migrated from https://drupal.org/node/1963480
@ghost ghost assigned greg-1-anderson Sep 1, 2013
greg-1-anderson added a commit to greg-1-anderson/drush that referenced this issue Sep 1, 2013
@greg-1-anderson
drush-ops#52: Automatically set the label separator to the list separ…
18d817d 
…ator when csv, etc. is selected with @sites (or other multi-site commands)
@greg-1-anderson
Copy link
Member Author

I guess I should have made the commit first; then I could have made an ordinary PR. Oh well, still doing things the old d.o way. It works; next time I'll make a PR. At least I've fixed my forked repository, so I don't have to make branches on drush-ops any more. :p

@greg-1-anderson
Copy link
Member Author

So, the challenge here is that the output format engine is not initialize in the pre-dispatch handler, so we need some extra code to set it up. However, I realized that this is a bit more involved than necessary.

Meta: set status "needs work".

greg-1-anderson added a commit to greg-1-anderson/drush that referenced this issue Sep 1, 2013
@greg-1-anderson
drush-ops#52: Simplify code to automatically set the label separator.
20a7e31
@greg-1-anderson
Copy link
Member Author

Okay, there's no need to initialize the whole command and engine contexts. Commit above simplifies.

Meta: set status "needs review".

@weitzman
Copy link
Member

weitzman commented Sep 3, 2013

I made a PR for line by line editing so this is now closed in favor of #56

@weitzman weitzman closed this as completed Sep 3, 2013
greg-1-anderson added a commit that referenced this issue Sep 3, 2013
@greg-1-anderson
#52: Automatically set the label separator to the list separator when…
09352ad 
… csv, etc. is selected with @sites (or other multi-site commands)
greg-1-anderson added a commit that referenced this issue Sep 3, 2013
@greg-1-anderson
#52: Simplify code to automatically set the label separator.
f9d4f05
greg-1-anderson added a commit that referenced this issue Sep 4, 2013
@greg-1-anderson
#52: Automatically set the label separator to the list separator when…
f94f3c3 
… csv, etc. is selected with @sites (or other multi-site commands)
greg-1-anderson added a commit that referenced this issue Sep 4, 2013
@greg-1-anderson
#52: Simplify code to automatically set the label separator.
bff8961
mradcliffe pushed a commit to mradcliffe/drush that referenced this issue Sep 12, 2013
@greg-1-anderson @mradcliffe
drush-ops#52: Automatically set the label separator to the list separ…
3e78881 
…ator when csv, etc. is selected with @sites (or other multi-site commands)
mradcliffe pushed a commit to mradcliffe/drush that referenced this issue Sep 12, 2013
@greg-1-anderson @mradcliffe
drush-ops#52: Simplify code to automatically set the label separator.
65d3cd3
mradcliffe pushed a commit to mradcliffe/drush that referenced this issue Sep 12, 2013
@greg-1-anderson @mradcliffe
drush-ops#52: Automatically set the label separator to the list separ…
00e7f0f 
…ator when csv, etc. is selected with @sites (or other multi-site commands)
mradcliffe pushed a commit to mradcliffe/drush that referenced this issue Sep 12, 2013
@greg-1-anderson @mradcliffe
drush-ops#52: Simplify code to automatically set the label separator.
0bebf5e
damiankloip pushed a commit to damiankloip/drush that referenced this issue Sep 26, 2013
@greg-1-anderson
drush-ops#52: Automatically set the label separator to the list separ…
d9f19d2 
…ator when csv, etc. is selected with @sites (or other multi-site commands)
damiankloip pushed a commit to damiankloip/drush that referenced this issue Sep 26, 2013
@greg-1-anderson
drush-ops#52: Simplify code to automatically set the label separator.
ab3f670
@renovate renovate bot mentioned this issue Nov 20, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg-1-anderson greg-1-anderson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weitzman @greg-1-anderson