Update site-install to use the recently added $class_loader parameter #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but this file is currently used for D7 as well. You can make this line conditional on D8 or duplicate this file and name the current one site_install7.inc |
|
Oops, yeah, that's a problem. But I mean who still uses D7 theses days... :-) I went for separate files. |
weitzman
added a commit
that referenced
this pull request
Dec 15, 2014
Update site-install to use the recently added $class_loader parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/node/2386247 added a $class_loader parameter to install_drupal().
This pull request updates the
site-installcommand to account for that.Note that Drupal currently has a BC-layer so that the current
site-installimplementation does not break.Also note that unfortunately this will break
site-installon anything other than the latest 8.0.x.See also https://www.drupal.org/node/2389243