Fix search path handling for top-level drush/ directory #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the search path discovery for top-level drush/ directories. ```php $searchpath[] = $drupal_root . '../drush'; ``` Translates to ```path/to/drupal/docroot../drush``` instead of ```path/to/drupal/docroot/../drush```. This breaks inclusion of drush configuration and commands and aliases within a top-level drupal/drush folder. The workaround is to use sites/all/drush. However, many users might not want to put custom commands and drush configurations in a web-servable location such as sites/all/drush -- especially custom commands and code. It's far safer to keep these commands and code outside of the server-executable context. The fix is to restore the slash that was there in drush 6. ```php $searchpath[] = $drupal_root . '/../drush'; ``` https://www.drupal.org/u/apotek
apotek
changed the title
|
I have tested this change and it works as described. |
greg-1-anderson
added a commit
that referenced
this pull request
Aug 12, 2015
Fix search path handling for top-level drush/ directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the search path discovery for top-level drush/ directories.
Translates to
path/to/drupal/docroot../drushinstead ofpath/to/drupal/docroot/../drush. This breaks inclusion of drush configuration and commands and aliases within a top-level drupal/drush folder.The workaround is to use sites/all/drush. However, many users might not want to put custom commands and drush configurations in a web-servable location such as sites/all/drush -- especially custom commands and code. It's far safer to keep these commands and code outside of the server-executable context.
Minimalist fix is to restore the slash that was there in drush 6.
https://www.drupal.org/u/apotek