#1637: Replace !var substitutions before calling D8 translate() #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, the Drupal-8.0.0-beta16 release due out tomorrow will remove support for the ! placeholder. We should therefore commit this, or some similar variant, ASAP so that Drush does not break when that change is committed. |
|
I'm happy to delegate this one to @greg-1-anderson. Thanks! |
|
Merging as-is, then. We can always adjust later, if changes are desired, but I think this should do the trick, and keep our unit tests running tomorrow. Thanks. |
greg-1-anderson
added a commit
that referenced
this pull request
Sep 30, 2015
#1637: Replace !var substitutions before calling D8 translate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal 8 may remove processing of !var substitutions. These are used all over Drush and also in Drush contrib modules; better to pre-process our strings before variable substitutions are removed for us by D8.