Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field:create command #3528

Closed
wants to merge 2 commits into from

Conversation

DieterHolvoet
Copy link
Contributor

This PR adds a command to create fields, similar to the field-create command that was present in Drush 8. It has already been used in multiple projects at the company I work at, and is in my opinion stable enough to be considered to be merged in Drush.

Tests

I do believe that this command should be backed by tests, but I have no past experience with PhpUnit and I can't seem to get the existing tests passing on my local machine, even without my changes.

Naming

I named the class FieldCreateCommands instead of FieldCommands because I think future (smaller) field-related commands should be kept seperate from the field-create command. The class is already almost 650 lines long and adding other commands would make it a bit too cluttered.

@weitzman
Copy link
Member

Yes, lets add tests before merging. We have a problem with tests that just arose, as you can see on the results of this PR.

@weitzman
Copy link
Member

Lets skip this command, as we now have generate field which is somewhat similar.

@weitzman weitzman closed this Aug 29, 2018
@DieterHolvoet
Copy link
Contributor Author

I just tried out generate field and it does something completely different. This command adds a new field to an entity type, it doesn't create a new field type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants