Try running the Drush 10 test suite with Drupal 9. #4232
Conversation
…hat depends on Drupal Code Generator compatibility.
| steps: | ||
| - checkout | ||
| - run: cp .docker/zz-php.ini /usr/local/etc/php/conf.d/ | ||
| - run: composer remove --dev webflo/drupal-core-strict --no-update |
There was a problem hiding this comment.
We can convert to drupal/core-recommended and drupal/dev-dependencies now, but let's do that as follow-on work.
There was a problem hiding this comment.
Once we convert, we won't have to just remove here.
.circleci/config.yml
Outdated
| @@ -126,6 +151,8 @@ workflows: | |||
| - check_mergable | |||
| - test_71_mysql: | |||
| <<: *requires | |||
| - test_72_drupal88: | |||
| <<: *requires | |||
| - test_72_highest: | |||
There was a problem hiding this comment.
We could rename this "drupal90" if desired.
There was a problem hiding this comment.
If it downloads Druapl 9, that rename seems wise.
| // TODO: re-enable this test once the Drupal Code Generator is | ||
| // compatible with Drupal 9. | ||
| if (version_compare('9.0.0', \Drupal::VERSION, '>=')) { | ||
| $this->markTestSkipped('Drupal Code Generator not working on Drupal 9 yet.'); |
There was a problem hiding this comment.
@Chi-teck Could you update DCG to add core_version_requirement to generated module info.yml files please?
| // TODO: re-enable this test once the pm:security command is | ||
| // compatible with Drupal 9. | ||
| if (version_compare('9.0.0', \Drupal::VERSION, '>=')) { | ||
| $this->markTestSkipped('pm:security not working on Drupal 9 yet.'); |
There was a problem hiding this comment.
I'm not really sure why pm:security is failing, but it might have something to do with lack of data for 9.x right now. I didn't look into it -- I figured it was better to just skip this test for now and circle back here later.
There was a problem hiding this comment.
Yeah, lack of 9.x update data blocks updating of https://github.com/drupal-composer/drupal-security-advisories upon which that command depends.
composer.lock
Outdated
| @@ -2517,16 +2516,16 @@ | |||
| }, | |||
| { | |||
| "name": "behat/mink-selenium2-driver", | |||
| "version": "1.3.x-dev", | |||
| "version": "dev-master", | |||
There was a problem hiding this comment.
Kinda surprised that is needed. Whats causing this?
There was a problem hiding this comment.
Good catch. I accidentally committed the wrong lock file. Pushed another commit that fixes it.
No description provided.