Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New no-dev option for security commands #4764

Merged
merged 3 commits into from
Jun 8, 2021

Conversation

prudloff-insite
Copy link
Contributor

We use drush sec and drush sec-php to check for vulnerabilities on our websites automatically, but we don't want to be notified for vulnerabilities in development dependencies because these are never installed on the server.

@weitzman
Copy link
Member

weitzman commented Jun 6, 2021

Code looks good except for a minor code style violation.

Ideally we exercise this new option in SecurityUpdatesTest and assert that the expected packages are considered.

@prudloff-insite
Copy link
Contributor Author

I added a basic test but I'm afraid it might break if someday there is indeed a security vulnerability in one of the production dependencies.

@weitzman weitzman merged commit c3b085e into drush-ops:10.x Jun 8, 2021
@weitzman
Copy link
Member

weitzman commented Jun 8, 2021

Thanks. Failing tests are unrelated. Prob a change in Drupal 9 updatedb-status formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants