Update deploy:hook command to use batch system #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weitzman
approved these changes
Jul 28, 2021
|
Just wanted to mention that I tested this with a deploy hook of mine that was causing out of memory issue. This PR fixed it :) Thanks! |
richardbporter
pushed a commit
to richardbporter/drush
that referenced
this pull request
Oct 14, 2021
* Update deploy:hook command to use batch system * fix coding standards 🙈 * strip tags from the exception translation so that it can be json encoded on windows :shurg: * try one last time to apease php on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original deploy:hook implementation passed the $sandbox variable to the deploy hooks to have the same signature as the post_update hooks. But we faked the batch process. However after using this for a while we found that it is necessary to do the batching in order to reduce the memory consumption that is unavoidable due to lots of static caches not being able to be cleared.