Remove unused param and only set tty when we can #5310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a Drupal 10 test failure "TTY mode requires /dev/tty to be read/writable."
| @@ -49,7 +50,10 @@ public function ssh(array $code, $options = ['cd' => self::REQ, 'tty' => false]) | |||
| } | |||
|
|
|||
| $process = $this->processManager()->siteProcess($alias, $code); | |||
| $process->setTty($options['tty']); | |||
| if (Tty::isTtySupported()) { | |||
There was a problem hiding this comment.
We still need to allow the user to select whether a TTY is desired or not. The other end of the connection might not support TTYs. I think that the tty CLI option should be preserved, and the $process->setTty($options['tty']); should merely be wrapped in if (Tty::isTtySupported()) {
There was a problem hiding this comment.
Ah right. I pushed a commit which does this.
The $options for ssh method did not need to declare 'tty' key since thats done by @optionset_proc_build
greg-1-anderson
requested changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a Drupal 10 test failure "TTY mode requires /dev/tty to be read/writable.". Example https://app.circleci.com/pipelines/github/drush-ops/drush/4320/workflows/70530dae-ef77-43cd-9fe9-d8f9713a71fa/jobs/25996/tests#failed-test-0